[Serve] Minor fix on bootstrap_done
#3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Feb 2, 2024
| @@ -183,6 +184,7 @@ def _get_desired_num_replicas(self) -> int: | |||
| # is not enabled, i.e. self.target_qps_per_replica is None. | |||
| # In this case, self.target_num_replicas will be min_replicas. | |||
| if self.target_qps_per_replica is None: | |||
| self.bootstrap_done = True | |||
There was a problem hiding this comment.
This seems having no effect, as this if condition will always short circuit the following calculation?
If it is the case, might be good to have a comment.
There was a problem hiding this comment.
This matters earlier in a subtle case where we do not set self.bootstrap_done=False during update.
I think since we decide to do that, as you mentioned, this will not have effect.
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh