Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace name variable by common_utils.get_user_hash() #3105

Merged

Conversation

msehsah1
Copy link
Contributor

@msehsah1 msehsah1 commented Feb 6, 2024

Replace the name variable by common_utils.get_user_hash() to resolve an issue where the SSH control path was too long, which caused problems with Unix domain sockets.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll
Copy link
Collaborator

Thanks for the contribution @mahmoudrasmyfathy1! Could you help run the ./format.sh to resolve the CI error? : )

@msehsah1
Copy link
Contributor Author

msehsah1 commented Feb 7, 2024

@Michaelvll , thank you for your support. I've run format.sh and all tests passed successfully. Awaiting your review.

sky/utils/command_runner.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 7d21885 into skypilot-org:master Feb 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants