Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show-gpus] Fix catalog API call for cudo compute #3149

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

Michaelvll
Copy link
Collaborator

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll changed the title [show-gpus] Fix API for cudo compute [show-gpus] Fix catalog API call for cudo compute Feb 12, 2024
Copy link
Collaborator

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want a sky show-gpus unit test to ensure it's runnable?

@Michaelvll
Copy link
Collaborator Author

We may want a sky show-gpus unit test to ensure it's runnable?

This is caught by the test of list_accelerators, but GitHub failed to catch the merge issue, and did not run the test with the master branch merged for that PR. A possible test flow for our future PR merging should be always trying to merge the master branch and test the tests locally (except for the smoke tests).

@Michaelvll Michaelvll merged commit bd8c2ea into master Feb 12, 2024
19 checks passed
@Michaelvll Michaelvll deleted the fix-test-for-cudo branch February 12, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants