[UX] sky check: show enabled clouds in a table
#3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks for improving this @concretevitamin! This is very useful! I was trying to find the enabled clouds in the long mixed instructions and clouds. LGTM.
sky/check.py
Outdated
Comment on lines
63
to
65
| 'If any problems remain, open an issue at: ' | ||
| 'https://github.com/skypilot-org/skypilot/issues/new', | ||
| dim=True)) |
There was a problem hiding this comment.
Maybe we can link to the installation page in our doc, which might be easier to see for the instructions: https://skypilot.readthedocs.io/en/latest/getting-started/installation.html
There was a problem hiding this comment.
Good call, done.
Could you help check if the new colors look good in light mode?
There was a problem hiding this comment.
Yes, it works nicely in the light mode:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tested (run the relevant ones):
bash format.shsky checkthensky launch --down -y --use-spot --cpus 2sky check -vpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh