Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix multi-node fail test and tpu tests #3167

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Feb 15, 2024

Fix smoke test for multi-node fail fast.
This also fixes a typo for TPU node, that causes test_tpu failure
Also, fixing the issue with the TPU VM tests, due to the API change for jax

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
    • pytest tests/test_smoke.py::test_multi_node_failure
    • pytest tests/test_smoke.py::test_tpu
    • pytest tests/test_smoke.py::test_tpu_vm
    • pytest tests/test_smoke.py::test_tpu_vm_pod
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll marked this pull request as ready for review February 15, 2024 21:06
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll! Test passes now!

@Michaelvll Michaelvll changed the title [Test] Fix multi-node fail test [Test] Fix multi-node fail test and tpu node Feb 15, 2024
@Michaelvll Michaelvll changed the title [Test] Fix multi-node fail test and tpu node [Test] Fix multi-node fail test and tpu tests Feb 15, 2024
@Michaelvll Michaelvll merged commit 4436aed into master Feb 16, 2024
19 checks passed
@Michaelvll Michaelvll deleted the fix-fail-test branch February 16, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants