Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] Use KUBECONFIG envvar to specify kubeconfig path #3169

Merged
merged 2 commits into from
Feb 16, 2024
Merged

[k8s] Use KUBECONFIG envvar to specify kubeconfig path #3169

merged 2 commits into from
Feb 16, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

@romilbhardwaj romilbhardwaj commented Feb 16, 2024 •
edited

Closes #3168.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Kubernetes smoke tests with KUBECONFIG set in env: export KUBECONFIG='~/mydir/config'; pytest tests/test_smoke.py --kubernetes -k "not TestStorageWithCredentials"

Michaelvll
Michaelvll approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @romilbhardwaj ! LGTM.

@romilbhardwaj
Copy link
Collaborator Author

Smoke tests pass (except test_huggingface), merging now.

@romilbhardwaj romilbhardwaj merged commit 3592950 into master Feb 16, 2024
19 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_kubeconfig_envvar branch February 16, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[k8s] Support $KUBECONFIG envvar for path to kubeconfig
2 participants
@romilbhardwaj @Michaelvll