Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Get rid of backup config file and fix identity check for service acocunt #3172

Merged
merged 9 commits into from
Feb 19, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Feb 17, 2024

Fixes #3171

We also removed the backup config file, as we got rid of ray autoscaler and will not have the problem where the GCP credential will be overwritten on the remote cluster.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Reproducible code for in [GCP] GCP should be enabled on the VM with service account assigned #3171
    • sky spot launch -n test-service --cloud gcp --cpus 2 echo hi with spot controller on AWS
    • sky spot launch -n test-service --cloud gcp --cpus 2 echo hi with spot controller on GCP
    • sky launch -c test-fm --cloud gcp ./examples/using_file_mounts.yaml with private buckets, without config set and login to check the GCP credentials used to check whether backup works.
  • All smoke tests: pytest tests/test_smoke.py --gcp
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
    • pytest tests/test_smoke.py::test_file_mounts --gcp with private buckets involved
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll marked this pull request as ready for review February 17, 2024 08:14
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

sky/clouds/gcp.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 1c063fb into master Feb 19, 2024
19 checks passed
@Michaelvll Michaelvll deleted the gcp-credentials branch February 19, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCP] GCP should be enabled on the VM with service account assigned
2 participants