Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Provisioner] Check ports for cloud not specified cases" #3175

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Revert "[Provisioner] Check ports for cloud not specified cases" #3175

merged 1 commit into from
Feb 17, 2024

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Feb 17, 2024

Reverts #3139

concretevitamin
concretevitamin approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting since it's causing certain SkyServe use cases failing.

@concretevitamin concretevitamin merged commit 30d0a51 into master Feb 17, 2024
19 checks passed
@concretevitamin concretevitamin deleted the revert-3139-upd-check-ports-for-no-cloud branch February 17, 2024 16:52
This was referenced Feb 18, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cblmemo @concretevitamin