-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spot] Fix memory contraint for spot controller and backward compatibility for spot commands #3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concretevitamin
approved these changes
Feb 21, 2024
…ilot into fix-spot-launch-memory
Michaelvll
changed the title
[Spot] Fix memory contraint for spot controller
[Spot] Fix memory contraint for spot controller and backward compatibility for spot commands
Feb 22, 2024
concretevitamin
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spot controller memory contraint.
This is a bug introduced by #3191.
This also fixes the issue with the job_lib assertion for spot jobs. To reproduce:
git checkout 053d0ba2b58705c3bc5540729eb5084911e7fa9a
;sky spot launch -n test-long-run --cloud gcp --cpus 2 -d "echo hi; sle ep 100000000000000"
sky checkout master
sky spot launch -n test-1 echo hi
sky spot logs 1
fails due to the assertionAfter this PR, it should fix this backward compat issue for the following two cases:
sky start sky-spot-controller-<hash>
, all the commands should work normally.Tested (run the relevant ones):
bash format.sh
sky spot launch -n test echo hi
without a controllerpytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh