Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Fix custom image parsing #3210

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[k8s] Fix custom image parsing #3210

merged 1 commit into from
Feb 22, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

Our current custom image text parsing for k8s uses lstrip incorrectly. The arg to lstrip specifies a set of characters, not a string. As a result, any image starting with the letters d,o,c,k,e,r or a permutation of docker gets parsed incorrectly:

>>> "rayproject/ray".lstrip('docker:')
'ayproject/ray'

Tested with the sky launch this YAML:

resources:
  cloud: kubernetes
  image_id: docker:rayproject/ray:2.4.0-py310-cpu

@romilbhardwaj romilbhardwaj added this to the v0.5 milestone Feb 22, 2024
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @romilbhardwaj! LGTM.

@romilbhardwaj romilbhardwaj merged commit 9f0b209 into master Feb 22, 2024
19 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_customimage_path branch February 22, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants