Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Fix spot with machine image #3236

Merged
merged 4 commits into from
Feb 26, 2024
Merged

[GCP] Fix spot with machine image #3236

merged 4 commits into from
Feb 26, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Feb 26, 2024

Fixes #3235

We have some missing configurations for launching spot instances on GCP with machine image, which seems caused by the API update of GCP.

Note: all the configs added are required to make spot work with machine image.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test-machine-image test.yaml
      resources:
        cloud: gcp
        region: us-west1
        image_id: projects/skypilot-xxxx/global/machineImages/test-machine-image
        cpus: 2+
        memory: 4+
        disk_size: 256
        use_spot: true
      
      num_nodes: 2
    • sky launch -c test-normal test.yaml
      resources:
        cloud: gcp
        region: us-west1
        cpus: 2+
        memory: 4+
        disk_size: 256
        use_spot: true
      
      num_nodes: 2
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll!

@Michaelvll Michaelvll merged commit 51e285e into master Feb 26, 2024
19 checks passed
@Michaelvll Michaelvll deleted the fix-spot branch February 26, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants