Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark CMake project explicitly as C++ #309

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

janisozaur
Copy link
Contributor

This prevents checking of C compiler

This prevents checking of C compiler
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dcc83b7 on janisozaur:patch-1 into be35975 on skypjack:master.

@skypjack skypjack self-assigned this Sep 10, 2019
@skypjack skypjack added the enhancement accepted requests, sooner or later I'll do it label Sep 10, 2019
@skypjack
Copy link
Owner

Good point, thanks. I'll merge it on master soon. 👍

@skypjack skypjack merged commit 85ff5f2 into skypjack:master Sep 10, 2019
@skypjack
Copy link
Owner

Unfortunately I must rollback this PR. If you enable BUILD_MOD, duktape is used to compile a test and therefore C is required. If you don't specify LANGUAGES, C and CXX are implicitly defined, that is all what is needed for EnTT and it's test suite.

@Innokentiy-Alaytsev
Copy link
Contributor

What about marking test using duktape as C and CXX language project?

@skypjack
Copy link
Owner

@Innokentiy-Alaytsev Can we mark a single test? I didn't even know that.
It's fine for me. May I ask you to open another PR for that?

@Innokentiy-Alaytsev
Copy link
Contributor

I'll check it out. The first thing I thought of was "We can set the language in test project declaration", but now I see that there are no separate projects for tests. I'll check out two ideas:

  1. Create placeholder-ish project for all tests.

  2. Set languages for separate target.

@Innokentiy-Alaytsev
Copy link
Contributor

Innokentiy-Alaytsev commented Sep 10, 2019

I'll prepare a pull request later this evening. My idea is to try to call enable_language if BUILD_MOD is true.

@skypjack
Copy link
Owner

Thank you. Really appreciated!! 😉

skypjack added a commit that referenced this pull request Sep 10, 2019
@skypjack
Copy link
Owner

Added to wip as you pointed out @Innokentiy-Alaytsev .
I put the call to enable_language in the file in the top directory as suggested by the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement accepted requests, sooner or later I'll do it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants