DNM: doParallel in gwemopt #4934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-migration?
Theodlz
reviewed
May 15, 2024
| @@ -421,7 +421,8 @@ def generate_plan( | |||
| # single set of scheduled observations | |||
| 'doSingleExposure': True, | |||
| # parallelize computation | |||
| 'doParallel': False, | |||
| 'doParallel': True, | |||
| 'Ncores': 4, | |||
There was a problem hiding this comment.
Quick reminder that once that works and you are happy with it, a following PR could (and should) make this quantity configurable in the config file so different instances can allocate resources as required).
|
@mcoughlin did you have a chance to share the exact error msg this gives you? Maybe you already did, just didn't remember where I could find it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on parallelization in gwemopt.