-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: /meme #34
feat: /meme #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also some feedback about the site:
- As mentioned, there has to be a list of templates like imgflip. Clicking an empty template should show a preview of what that meme could look like with some template text and images.
- Rather than relying on imgflip URLs we should download and rehost the templates. This is important because if imgflip ever goes down or deletes a template then we should not be affected. For example just last week Imgur announced they'd be removing sexually explicit and content uploaded anonymously (i.e. through sharex and such) which means LOTS of images on the web will soon be dead links. (see: https://www.reddit.com/r/RelayForReddit/comments/12uoqaz/imgur_is_updating_their_tos_on_may_15_2023_all/).
- This means the website will need some kind of CDN service. We can hopefully use https://www.cloudflare.com/cdn/ for this.
- The website is Nuxt so we can use server routes for the GETs and POSTs, no need for a separate process.
- The JSON below the generator will show something like
https://cdn.memes.skyra.pw.com/{{name}}.{{ext}}
or however CloudFlare CDN works.
- The UX of the sliders for X and Y is actually horrid wtf. Why is it a circle in a box. If you want more than something simple at least look like https://www.frontendplanet.com/css-range-slider-examples/ but it really should just be a bar with a circle, not a box with a circle.
- On that note, it would be better if we can move the box on the image itself just like imgflip. Width and height in particular are annoying to control now because they are from-center instead of from-edge so if I have just positioned it correctly on the left X axis then start making it smaller I need to go back to X and place that again and repeat and repeat and repeat.
- X, Y, Width, Height, and rotation should allow for manual number input. Right now it's really hard to do pixel perfect placements. This is partially solved by 3 and 4, but not entirely. I know there is a checkbox for this but it should be both slides and number input by default, no checkbox. I didn't realise the checkbox was there until I went back and checked for the JSON structure. If I can't find it then simple end-users definitely can't.
- What are "Boxes". Boxes of text? Boxes of other memes? Boxes of cows? Specify. And no not to me, I know you meant text, specify it on the website.. For example see how imgflip specifically calls them
Text #1
andText #2
.
- Providing an invalid link (i.e. https://i.imgflip.com/65exzi.mp4) will show the default message of having to provide an URL instead of an error.
- We should add some form of admin dashboard so we can delete templates, right now people can theoretically link pornographic images and we'll never know.
- On that note, we should use some form of external image scanning service that tells us whether the image is explicit or not, and reject it if it is. I'm sure there is some API out there that is free or has an open source plan.
and otherwise can train our own ML by getting all the content from imgflip as "good" results and pornographic content as bad stuff /s no thx - Text should be more adjustable. Looking at imgflip again:
- All caps
- Bold
- Italic
- Outline width
- Max font size
- Text align
- Vertical align
- Opacity
|
||
## Submitting new memes | ||
|
||
To submit new memes, please check whether or not the [`memes.json`](https://github.com/skyra-project/artiel/blob/main/src/generated/data/memes.json) file already includes your meme. If it doesn't, feel free to submit a new one using https://memes.skyra.pw, then follow the [Contributing Guide](https://github.com/skyra-project/.github/blob/main/.github/CONTRIBUTING.md) to get best acquainted with the development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The site should have an overview of memes that already exist. Simple users aren't going to check a cumbersome JSON. Take for example https://imgflip.com/memetemplates
|
Yes. We reference the JSON. Or if you really wanna go the extra mile then do the DJS docs route where the client queries a CF worker function for full text search and that same worker function in turn periodically refreshes the JSON from GitHub but 🤷
You don't quite get it. I'm talking about both. You can do the slider above and then instead of making the text a string just make it an underline style text field (like the "standard" variant of MUI https://mui.com/material-ui/react-text-field/#basic-textfield) so people can click or tap it and enter their own number.
Nonsense. Sliders work just fine on touch devices. No idea where you get this from.
It also doesn't take all that much to regex check the extension... In fact, you can copy the regex from Skyra's code.
I guess we can forego rehosting for now. We will want some form of admin dashboard still, but we don't need to as strict on content approval then because the content isn't hosted by us. |
No description provided.