feat!: rewrite to lit #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Members is not a mentionable and won't become one in near future, because it's an tab only moderators+ can see. |
Good point. We can skip it for now. |
|
Imma lyk if it changes |
step 1: clean out most of the stencil code
BREAKING CHANGES: pending
…to make proper bundles
|
Finished rebasing the branch so it's clean to work in again |
Lulalaby
reviewed
Sep 3, 2023
This needs expanding through our alpha period
kyranet
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO taken from #337
Something weird is happening with ephemeral replies. I can't quite find out what and why:
Also in non ephemeral with compact mode the text doesn't center out correctly with the username:
Some things I am noticing that I'd just like to drop here:
Kinda mentioned it before but there are some wacky things with compact mode. Outlining, font sizes, etc.
The icon for channel mentions isn't properly aligned.
. I can't tell for sure myself but I also think the other mention SVGs are slightly misaligned.
DiscordLinkdoesn't use the consumer for lightTheme yetUpdate all codesandbox links (post releasing alpha version)
Add Svelte and Sveltekit codesandbox links
Will probably edit this message as I progress further writing unit tests