feat(Monitor): add decorators #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quantumlyy
force-pushed
the
feat/decorators/monitors
branch
from
db59d39
to
4519158
Compare
adiologydev
previously approved these changes
Jul 22, 2020
cfanoulis
suggested changes
Jul 22, 2020
cfanoulis
previously approved these changes
Jul 22, 2020
favna
force-pushed
the
feat/decorators/monitors
branch
from
2f9f262
to
53d4165
Compare
favna
approved these changes
Jul 22, 2020
kyranet
requested changes
Jul 22, 2020
There was a problem hiding this comment.
Monitor's properties should be fields if anything.
But another thought I had was to remove the checks and let users implement their own. Not all bots need the overhead of having to check fields that are always the same for all monitors. Skyra provides a custom Monitor class which has its own condition methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.