-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Monitor): add decorators #7
Conversation
db59d39
to
4519158
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename src/lib/types/Enums.ts back to a .d.ts file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after talk in Discord
2f9f262
to
53d4165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Monitor's properties should be fields if anything.
But another thought I had was to remove the checks and let users implement their own. Not all bots need the overhead of having to check fields that are always the same for all monitors. Skyra provides a custom Monitor class which has its own condition methods.
No description provided.