Issue/3336 repeated style

[Dora1604]

Fix issue #3336 with repeated styles

This pull request fixes issue #3336.

When calling getFormat() and finding multiple style value, there were two options to solve this issue:

• Adding already existing style to style array which means it is in an array twice
• Skipping and continue looping

I decided to go with second option because it fits more with the existing code.

Code

In combineFormats function, I changed this code block:

if (combined[name].indexOf(formats[name]) < 0) {
  merged[name] = combined[name].concat([formats[name]]);
} else {
  // Here is the change
  merged[name] = combined[name];
}

The whole function:

function combineFormats(formats, combined) {
  return Object.keys(combined).reduce((merged, name) => {
    if (formats[name] == null) return merged;
    if (combined[name] === formats[name]) {
      merged[name] = combined[name];
    } else if (Array.isArray(combined[name])) {
      if (combined[name].indexOf(formats[name]) < 0) {
        merged[name] = combined[name].concat([formats[name]]);
      } else {
        // If style already exists continue looping but do not lose other styles
        merged[name] = combined[name];
      }
    } else {
      merged[name] = [combined[name], formats[name]];
    }
    return merged;
  }, {});
}

If you have any questions, I am opened to discussion. I hope you get to merge this pull request. Let me know if it is good. Thanks!

[jhchen]

Thanks!