Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge adjacent code blocks for correct multi-line highlighting #737

Closed
wants to merge 1 commit into from

Conversation

micimize
Copy link

@micimize micimize commented Jun 7, 2016

this resolves #723 with the same optimization strategy as lists.

@jhchen
Copy link
Member

jhchen commented Jun 7, 2016

I did previously attempt an implementation strategy like this and ran into many issues having to do with creating and removing newlines and across different browsers, particularly at the end of a code block. One example is create a newline at the end of the block, type a character, hit enter, nothing happens when a newline should be created. This PR has those issues as well.

I'm supportive of the idea in general of using one <pre> to enclose multiple lines of code as it is also more semantic, but there are some edge case behaviors that need to be addressed.

All PRs should also not break any existing tests: https://github.com/quilljs/quill/blob/develop/.github/CONTRIBUTING.md#pull-requests.

@jhchen jhchen closed this Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax module does not correctly highlight multi-line comments
2 participants