Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openid connect #1242

Merged
merged 3 commits into from Feb 10, 2024
Merged

Openid connect #1242

merged 3 commits into from Feb 10, 2024

Conversation

danielmichaels
Copy link
Contributor

This PR adds support for Sign in with Slack, in particular the openid.connect.token endpoint.

I've tried to keep consistency with the other methods found in oauth.go by providing context and non-context aware functions.

Two functions were also incorrectly commented which have also been addressed in this PR.

make pr-prep passed.

Related: #967

@parsley42 parsley42 closed this Feb 10, 2024
@parsley42 parsley42 reopened this Feb 10, 2024
Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears useful / not harmful

@parsley42 parsley42 merged commit 9cc451b into slack-go:master Feb 10, 2024
4 checks passed
@danielmichaels danielmichaels deleted the openid-connect branch February 12, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants