Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timepicker to UnmarshalJSON #918

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Add timepicker to UnmarshalJSON #918

merged 1 commit into from
Apr 17, 2021

Conversation

tapih
Copy link
Contributor

@tapih tapih commented Apr 1, 2021

timepicker does not exist under the switch in UnmarshalJSON, and the socket mode client failed to parse incoming messages saying unsupported block element type timepicker.

@kanata2 kanata2 mentioned this pull request Apr 17, 2021
Closed
@kanata2 kanata2 added the bugfix [PR] bugfix label Apr 17, 2021
kanata2
kanata2 approved these changes Apr 17, 2021
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@kanata2 kanata2 merged commit 1c59c6d into slack-go:master Apr 17, 2021
@oogali oogali mentioned this pull request Apr 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
bugfix [PR] bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tapih @kanata2