Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing restart logic #203

Merged
merged 9 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@RodneyU215
Copy link
Contributor

RodneyU215 commented Oct 30, 2018

Summary

  1. The method #restart! has been removed from SlackRubyBot::Server. It was causing issues with the restart logic that was recently added to slack-ruby-client.

Requirements

@dblock

This comment has been minimized.

Copy link
Collaborator

dblock commented Oct 30, 2018

Lets clarify what people are supposed to do in UPGRADING, make a major version bump, and lock the version of slack-ruby-bot to the next version of slack-ruby-client in .gemspec part of this PR.

Show resolved Hide resolved CHANGELOG.md Outdated
@RodneyU215

This comment has been minimized.

Copy link
Contributor Author

RodneyU215 commented Oct 30, 2018

@dblock I've addressed the feedback. Please let me know how you'd like to move forward. If my understanding is correct, these changes won't be compatible until we release a new version of slack-ruby-client.

@dblock
Copy link
Collaborator

dblock left a comment

We do need a passing build first. Change the reference to slack-ruby-client HEAD via Gemfile, get it to 💚

Show resolved Hide resolved UPGRADING.md Outdated

@dblock dblock referenced this pull request Oct 30, 2018

Closed

Slack-side disconnects #208

@RodneyU215

This comment has been minimized.

Copy link
Contributor Author

RodneyU215 commented Oct 30, 2018

It's finally ready! 🎉😅

@dblock

This comment has been minimized.

Copy link
Collaborator

dblock commented Oct 31, 2018

I'll keep this open for now till we can at least feature complete slack-ruby/slack-ruby-client#223 for other async IO implementations.

@dblock

This comment has been minimized.

Copy link
Collaborator

dblock commented Jan 6, 2019

Care to rebase this @RodneyU215 ? I'll merge.

@dblock dblock merged commit 962643b into slack-ruby:master Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.