Removing restart logic #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets clarify what people are supposed to do in UPGRADING, make a major version bump, and lock the version of slack-ruby-bot to the next version of slack-ruby-client in .gemspec part of this PR. |
dblock
reviewed
Oct 30, 2018
|
@dblock I've addressed the feedback. Please let me know how you'd like to move forward. If my understanding is correct, these changes won't be compatible until we release a new version of |
dblock
reviewed
Oct 30, 2018
|
It's finally ready! 🎉😅 |
|
I'll keep this open for now till we can at least feature complete slack-ruby/slack-ruby-client#223 for other async IO implementations. |
|
Care to rebase this @RodneyU215 ? I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#restart!has been removed fromSlackRubyBot::Server. It was causing issues with the restart logic that was recently added toslack-ruby-client.Requirements