Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked README to fix autoreconf #116

Merged
merged 1 commit into from Jul 2, 2017
Merged

Linked README to fix autoreconf #116

merged 1 commit into from Jul 2, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2017

Autoreconf is needed on some distros to compile correctly, but it doesn't work without a README file.

@brlin-tw
Copy link
Collaborator

brlin-tw commented Jul 2, 2017

Hello, can you provide an instruction to reproduce this issue?

@ghost
Copy link
Author

ghost commented Jul 2, 2017

On some Arch Linux installations, running autoconf complains about

libtool: Version mismatch error. This is libtool 2.4.2 Debian-2.4.2-1ubuntu1, but the
libtool: definition of this LT_INIT comes from libtool 2.4.6.
libtool: You should recreate aclocal.m4 with macros from libtool 2.4.2 Debian-2.4.2-1ubuntu1
libtool: and run autoconf again.

which can be fixed by running autoreconf --force --install, but that then complains about

Makefile.am: error: required file './README' not found

Which is fixed by either creating an empty README file or linking README.md.

@brlin-tw
Copy link
Collaborator

brlin-tw commented Jul 2, 2017

I wonder if the Makefile.am can be fixed by not requiring README but README.md, please avoid workarounding issue by adding redundant file

@ghost
Copy link
Author

ghost commented Jul 2, 2017

Apparently yes, by setting AUTOMAKE_OPTIONS from gnu to foreign.

@brlin-tw
Copy link
Collaborator

brlin-tw commented Jul 2, 2017

Can you verify the fix is working? My automake still complaining about the missing ./README

@ghost
Copy link
Author

ghost commented Jul 2, 2017

darkfm@arch-bedroom ~/WoeUSB (git)-[master] % autoreconf --force --install
aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in'
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in'
automake: warning: autoconf input should be named 'configure.ac', not 'configure.in'
configure.in:12: installing './compile'
configure.in:3: installing './missing'
automake: warning: autoconf input should be named 'configure.ac', not 'configure.in'
src/Makefile.am:5: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
src/Makefile.am: installing './depcomp'
darkfm@arch-bedroom ~/WoeUSB (git)-[master] % ./configure
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
...
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating src/data/Makefile
config.status: creating src/linux-menu/Makefile
config.status: creating src/win32/Makefile
config.status: creating src/locale/Makefile
config.status: creating src/locale/fr/Makefile
config.status: creating src/locale/fr/LC_MESSAGES/Makefile
config.status: creating debian/Makefile
config.status: creating innoSetup/Makefile
config.status: creating src/config.hpp
config.status: executing depfiles commands
config.status: executing libtool commands

####################################

The package is now configured. You should type make !
    DEBUG MODE          : disable.
    TARGET PLATFORM     : linux.
    INSTALLATION PREFIX : /usr/local.

####################################

Uhh... works for me?

@brlin-tw
Copy link
Collaborator

brlin-tw commented Jul 2, 2017

I found the problem, can you remove the AUTOMAKE_OPTIONS = * assignment in Makefile.am and instead modify the AM_INIT_AUTOMAKE() line in configure.ac to AM_INIT_AUTOMAKE([foreign]) ?

Ref: c - Use autotools with README.md - Stack Overflow

@ghost
Copy link
Author

ghost commented Jul 2, 2017

It should work now

@brlin-tw brlin-tw merged commit 57a510b into slacka:master Jul 2, 2017
@brlin-tw
Copy link
Collaborator

brlin-tw commented Jul 2, 2017

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants