Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sarah Jiang <srajiang@gmail.com>
  • Loading branch information
seratch and srajiang committed Aug 25, 2021
1 parent 516d5b7 commit c1c7b9c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/receivers/ExpressReceiver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export default class ExpressReceiver implements Receiver {
userScopes: installerOptions.userScopes,
});
if (installerOptions.directInstall) {
// If a Slack app sets "Direct Install URL" in the Slack app configruation,
// If a Slack app sets "Direct Install URL" in the Slack app configuration,
// the installation flow of the app should start with the Slack authorize URL.
// See https://api.slack.com/start/distributing/directory#direct_install for more details.
res.redirect(url);
Expand Down
2 changes: 1 addition & 1 deletion src/receivers/SocketModeReceiver.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ describe('SocketModeReceiver', function () {
assert(fakeRes.writeHead.calledWith(200, sinon.match.object));
assert(fakeRes.end.called);
});
it('should rediect installers if directInstallEnabled is true', async function () {
it('should redirect installers if directInstall is true', async function () {
// Arrange
const installProviderStub = sinon.createStubInstance(InstallProvider);
const overrides = mergeOverrides(
Expand Down

0 comments on commit c1c7b9c

Please sign in to comment.