Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the /slack/install oauth installation handler sets the content-type in its HTTP response #1279

Closed
1 task done
filmaj opened this issue Jan 20, 2022 · 0 comments · Fixed by #1280
Closed
1 task done

Ensure the /slack/install oauth installation handler sets the content-type in its HTTP response #1279

filmaj opened this issue Jan 20, 2022 · 0 comments · Fixed by #1280
Assignees
@filmaj
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Milestone
3.10.0

Comments

@filmaj
Copy link
Contributor

filmaj commented Jan 20, 2022

Description

This was filed internally at Slack, but, if you look at this code, the default HTTPReceiver OAuth installation handler response explicitly does not set a Content-Type HTTP response header. While most browsers can deal with this automatically, some hosting providers (like AWS' API Gateway) does not.

Suggestion: we set the content-type header explicitly in this area of the code.

What type of issue is this? (place an x in one of the [ ])

  • bug
@filmaj filmaj added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Jan 20, 2022
@filmaj filmaj added this to the 3.10.0 milestone Jan 20, 2022
@filmaj filmaj self-assigned this Jan 20, 2022
filmaj added a commit that referenced this issue Jan 20, 2022
@filmaj
Fixes #1279: explicitly set the content-type on HTTPReceiver response…
ddf0259 
…s to the /slack/install route.
@filmaj filmaj mentioned this issue Jan 20, 2022
Merged
filmaj added a commit that referenced this issue Jan 21, 2022
@filmaj
Fixes #1279: explicitly set the content-type on HTTPReceiver response…
fbd79ed 
…s to the /slack/install route.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filmaj filmaj

Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Milestone
3.10.0
1 participant
@filmaj