Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving fully to eslint, removing prettier #1024

Merged
merged 49 commits into from
Aug 27, 2021
Merged

Moving fully to eslint, removing prettier #1024

merged 49 commits into from
Aug 27, 2021

Commits on Aug 27, 2021

  1. Combining lint rules into one .eslintrc.js file, removing prettier, m… 

    …oving fully to eslint from tslint. All of these changes are courtesy of @aoberoi and the work they put into #669 🙇
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    2d03506 View commit details
    Browse the repository at this point in the history

  2. Update eslint-config-airbnb-typescript to v12 from v8 - eliminates pe… 

    …er dependencies
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    f661ff7 View commit details
    Browse the repository at this point in the history

  3. Use main tsconfig for mocha test run.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    d3f8e47 View commit details
    Browse the repository at this point in the history

  4. Add a src/types-specific rule for allowing type properties to be name… 

    …d using snake_case
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    7dbf5a2 View commit details
    Browse the repository at this point in the history

  5. Accept both camel and snake case for src/types/**/*.ts type properties.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a0e4517 View commit details
    Browse the repository at this point in the history

  6. Fix import ordering in files - passes import/order lint rules.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    31156fb View commit details
    Browse the repository at this point in the history

  7. Fix indentation linter warnings

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    df80a44 View commit details
    Browse the repository at this point in the history

  8. Fix ban-types linter errors

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    7fad415 View commit details
    Browse the repository at this point in the history

  9. Do not use generators to iterate over arrays, use array iterators ins… 

    …tead. Dedupe some copy-pasted test helpers from AwsReceiver spec. Move a linter ignore directive from tslint to eslint.
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    2a136ec View commit details
    Browse the repository at this point in the history

  10. Remove extraneous interface, ignore unused type

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    d2e26ad View commit details
    Browse the repository at this point in the history

  11. Fixing lint errors for "no-use-before-define" rule.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    cc9ffb5 View commit details
    Browse the repository at this point in the history

  12. Fix missing function return types

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    1eebc5b View commit details
    Browse the repository at this point in the history

  13. Export a function by default in modules

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    81bdcd1 View commit details
    Browse the repository at this point in the history

  14. No multiple empty lines

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    90cc33c View commit details
    Browse the repository at this point in the history

  15. Fixing space after block comment.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    abdafa5 View commit details
    Browse the repository at this point in the history

  16. Disable property-on-param reassignment warning for test helper code

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    f1d06ca View commit details
    Browse the repository at this point in the history

  17. Fixing no-undef-init rules

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    bbabb64 View commit details
    Browse the repository at this point in the history

  18. Fixing no-shadow lint rule failures.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    cc545b8 View commit details
    Browse the repository at this point in the history

  19. Fix object-shorthand lint rule failures.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    84a8e7e View commit details
    Browse the repository at this point in the history

  20. Fix failing no-empty-pattern rule; reuse the noop test handler wher… 

    …e possible.
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    e98755d View commit details
    Browse the repository at this point in the history

  21. Fix arrow-body-style lint failures.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    5fb8a1f View commit details
    Browse the repository at this point in the history

  22. Fix max length of line

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    695540e View commit details
    Browse the repository at this point in the history

  23. Remove type-specific snake_case naming rules and subsume into global … 

    …naming conventions.
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    c7909df View commit details
    Browse the repository at this point in the history

  24. Formatting, max-len and newline fixes

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    fc8f4d5 View commit details
    Browse the repository at this point in the history

  25. Formating, fixing unary operators, spacing, addressing one-off lint f… 

    …ailures.
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    62341a8 View commit details
    Browse the repository at this point in the history

  26. Remove unneeded package.json run scripts.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a3f95b1 View commit details
    Browse the repository at this point in the history

  27. Disable the only occurrences of no-nested-ternary - but is this the r… 

    …ight approach?
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    40bc25d View commit details
    Browse the repository at this point in the history

  28. Attempt at rewriting nested ternary payload assignment into a switch.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    47ea9c8 View commit details
    Browse the repository at this point in the history

  29. Specify type of payload when processing events

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    df0a65f View commit details
    Browse the repository at this point in the history

  30. Turn off no-inferrable-types linting rule

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    ec00e2a View commit details
    Browse the repository at this point in the history

  31. Tweak the operator-linebreak lint rule: forbid line breaks around the… 

    … = operator, and prefix for other operators to be at the end of the line.
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    04bb01f View commit details
    Browse the repository at this point in the history

  32. Expand allowed source directories where one may reach into their subd… 

    …irectories to import submodules from.
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a3df370 View commit details
    Browse the repository at this point in the history

  33. Remove strict-boolean-expressions rule. This rule effectively prevent… 

    …s the use of short-circuit logical operators (|| and &&).
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    60e81e9 View commit details
    Browse the repository at this point in the history

  34. Disable max-classes-per-file rule.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    03bfdff View commit details
    Browse the repository at this point in the history

  35. Enum members should use PascalCase.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    1523503 View commit details
    Browse the repository at this point in the history

  36. Add test-specific ruleset and disable prefer-arrow-callback for tests. 

    Allow use of "as Type" syntax for type assertions in test code.

Dont force symbol descriptors in test code
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    29ecb16 View commit details
    Browse the repository at this point in the history

  37. Allow unused vars and args to exist if they have a leading underscore… 

    … in their name
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    7fd5213 View commit details
    Browse the repository at this point in the history

  38. Fix lint error for missing accessibility modifier on class methods

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    edd9490 View commit details
    Browse the repository at this point in the history

  39. Fix lint errors for operator linebreaks.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    600546b View commit details
    Browse the repository at this point in the history

  40. Ignore import lint rules around use of require for importing package.… 

    …json
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    b2cc2a5 View commit details
    Browse the repository at this point in the history

  41. Fixing consistent-return linter warnings.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    97c708c View commit details
    Browse the repository at this point in the history

  42. Removing no-longer-needed eslint ignore directives, making explicit t… 

    …he accessibility of constructors for various classes.
    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    9cdc81d View commit details
    Browse the repository at this point in the history

  43. Removing no longer needed tslint directives.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    814aec5 View commit details
    Browse the repository at this point in the history

  44. Remove unnecessary dependency

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    bcb5d85 View commit details
    Browse the repository at this point in the history

  45. Fix @typescript-eslint/ban-types linter failure

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    c0a57ac View commit details
    Browse the repository at this point in the history

  46. Fixing up bad merge

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    bafe97e View commit details
    Browse the repository at this point in the history

  47. New lint fixes for new test file.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    3914689 View commit details
    Browse the repository at this point in the history

  48. Move an eslint dependency to devDependencies.

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    feb7f79 View commit details
    Browse the repository at this point in the history

  49. Remove unnecessary type declaration / fix linter warning

    @filmaj
    filmaj committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a0104e6 View commit details
    Browse the repository at this point in the history