Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Config Migration: Object property names enclosed with quotes require no naming convention #1051

Closed
wants to merge 1 commit into from

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 9, 2021

Summary

This is a PR that should be merged into #1024 and incrementally addresses #842.

This PR tweaks the naming convention rule such that object properties enclosed in quotes do not need to adhere to specific naming conventions. This is useful for things like specifying HTTP header names as properties on an object, since HTTP header names typically use a kabob-case naming convention (usually capitalized, too).

Impact

Before

✖ 765 problems (576 errors, 189 warnings)
  103 errors and 0 warnings potentially fixable with the `--fix` option.

After

✖ 761 problems (572 errors, 189 warnings)
  103 errors and 0 warnings potentially fixable with the `--fix` option.

Requirements (place an x in each [ ])

@filmaj filmaj added the tests M-T: Testing work only label Aug 9, 2021
@filmaj filmaj self-assigned this Aug 9, 2021
…nclosed with quotes do not have to adhere to any specific naming convention.
@filmaj
Copy link
Contributor Author

filmaj commented Aug 10, 2021

Hmm, it seems like this PR is no longer needed as the targeted rule passes now on the base PR. Well, great, I guess! Closing.

@filmaj filmaj closed this Aug 10, 2021
@filmaj filmaj deleted the names-with-quotes branch August 10, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant