[WIP] Add app_id and metadata to generic message event #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srajiang
changed the title
srajiang
added
enhancement
srajiang
force-pushed
the
1064-message-metadata
branch
from
b33768b
to
403580b
Compare
seratch
changed the title
|
Resolved by #1508 Let me close this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1064 - Adds app_id and metadata fields to the generic message event.
I haven't added these fields for the other message subtype events since I'm assuming these system generated events won't pass along any custom metadata.
Tasks
Requirements (place an
xin each[ ])