Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1040 Remove invalid warning logs for logger initialization #1078

Merged
merged 1 commit into from Aug 24, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 24, 2021

Summary

This pull request resolves #1040. refer to the issue for details.

Requirements (place an x in each [ ])

@seratch seratch added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Aug 24, 2021
@seratch seratch added this to the 3.7.0 milestone Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1078 (d3fb018) into main (0ad0e89) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
- Coverage   68.89%   68.84%   -0.06%     
==========================================
  Files          13       13              
  Lines        1212     1210       -2     
  Branches      357      356       -1     
==========================================
- Hits          835      833       -2     
  Misses        304      304              
  Partials       73       73              
Impacted Files Coverage Δ
src/App.ts 82.81% <ø> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad0e89...d3fb018. Read the comment docs.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement to me! Both the logic and the warning are confusing to me 😆

@seratch
Copy link
Member Author

seratch commented Aug 24, 2021

Thanks for your reviews! I think that this pull request is ready for merge already. Let me merge this one now.

@seratch seratch merged commit f90a306 into slackapi:main Aug 24, 2021
@seratch seratch deleted the issue-1040-logging branch August 24, 2021 21:31
@seratch seratch self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't provide custom logger and configure log level without warnings
3 participants