Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #868 Add ability to use a custom express app and/or router to ExpressReceiver #1084

Merged
merged 1 commit into from Aug 25, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 25, 2021

Summary

This pull request resolves #868. With this change, developers can easily embed Bolt app endpoints in existing Express applications.

Requirements (place an x in each [ ])

@seratch seratch added the enhancement M-T: A feature request for new functionality label Aug 25, 2021
@seratch seratch added this to the 3.7.0 milestone Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #1084 (8975e85) into main (02d601d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   68.73%   68.79%   +0.05%     
==========================================
  Files          13       13              
  Lines        1206     1208       +2     
  Branches      355      359       +4     
==========================================
+ Hits          829      831       +2     
  Misses        304      304              
  Partials       73       73              
Impacted Files Coverage Δ
src/receivers/ExpressReceiver.ts 66.66% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d601d...8975e85. Read the comment docs.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for adding this!

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

What, if any, documentation additions would be needed for this? Interestingly, there seems to be some discussion at least around the router property included in this PR on the custom routes docs - and it even says that that's been a feature since 2.1!? Something doesn't add up here...

@seratch
Copy link
Member Author

seratch commented Aug 25, 2021

@filmaj

What, if any, documentation additions would be needed for this?

We can update the custom routes document to use HTTPReceiver(current default receiver) once we release #866 (@misscoded is working on it now). I will create a new task issue for it.

@seratch seratch merged commit 99df66a into slackapi:main Aug 25, 2021
@seratch seratch deleted the issue-868-passing-express branch August 25, 2021 22:40
@seratch seratch self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to use a custom express app and/or router to ExpressReceiver
3 participants