add documentation how to listen to view_closed events #1010 #1214
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
=======================================
Coverage 73.20% 73.20%
=======================================
Files 17 17
Lines 1437 1437
Branches 431 431
=======================================
Hits 1052 1052
Misses 300 300
Partials 85 85 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi @TheManWhoStaresAtCode - thank you for submitting this improvement to the docs!
I have done a first pass, and left some comments to help standardize the language.
* implement review comments Co-authored-by: Sarah Jiang <srajiang@gmail.com>
TheManWhoStaresAtCode
force-pushed
the
view_closed_documentation_1010
branch
from
349e4fe
to
c5f02a0
Compare
docs/_basic/listening_modals.md
Outdated
|
|
||
| --- | ||
|
|
||
| ##### Update views on submission | ||
|
|
||
| You can access the value of the input blocks by accessing the `state` object. `state` contains a values object that uses the `block_id` and unique `action_id` to store the input values. |
There was a problem hiding this comment.
It's relevant to view_submission still, but it looks like some similar language is now incorporated on line 12 there anyway after your edits. Nice! So I think we could move this underneath the code sample with this current section too.
* further cleanup
|
Just to be sure: My current understanding is that all you requests are solved now and there is nothing to do from my side. If not please tell me what else needs to be adjusted. |
|
Thanks for your work @TheManWhoStaresAtCode ! |
|
hmm unfortunatly the code example for the view_closed event is not displayed properly - https://slack.dev/bolt-js/concepts#view-submissions 🤔 |
|
Hmm you are right. I tried playing around with the markdown structure / "section content" div, but it looks like we can only have one right "sidebar" example code per markdown page (otherwise they overlap, like you see on the live page). Maybe we can try to break out the view closed event and example into its own markdown page? |
|
I pushed up a fix in 4158bc5 - should be live shortly. |
|
thanks @filmaj - style is still a little bit broken but at least the code blocks are now available |
Summary
Fix #1010 Add documentation how to handle view_closed events as requested by #1010.
Requirements (place an
xin each[ ])