Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1231 Redundant code path inside an if/else block in App class #1327

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 23, 2022

Summary

This pull request resolves #1231 by refactoring the internals of the App class. This is just a minor internal improvement. Also, the AWS Lambda deployment topic mentioned in the issue should be unrelated.

Requirements (place an x in each [ ])

@seratch seratch added the enhancement M-T: A feature request for new functionality label Feb 23, 2022
@seratch seratch added this to the 3.10.0 milestone Feb 23, 2022
@seratch seratch self-assigned this Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1327 (9565b8c) into main (5ea31af) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 9565b8c differs from pull request most recent head a26e6c8. Consider uploading reports for the commit a26e6c8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
- Coverage   72.80%   72.76%   -0.04%     
==========================================
  Files          17       17              
  Lines        1467     1465       -2     
  Branches      437      436       -1     
==========================================
- Hits         1068     1066       -2     
  Misses        310      310              
  Partials       89       89              
Impacted Files Coverage Δ
src/App.ts 82.70% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea31af...a26e6c8. Read the comment docs.

@srajiang srajiang merged commit b4c8604 into slackapi:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant code path inside an if/else block in App class
3 participants