Simplify reaction_added/removed event's item type #1845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves TypeScript developer experience by updating "item" property type in reaction_added/removed event data types. WIth this change, developers can safely access
event.item.channel
in TS code. More importantly, they can usesay()
utlitity in listeners. Currently,say()
can be resolved asnever
in TS asevent.item.channel
can be absent for file/file comment items while it never happens. Slack apps no longer receive reaction events for files and file comments. So, this change is safe enough to apply in a patch release.Requirements (place an
x
in each[ ]
)