Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose user ID in context #1853

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

gilmatok
Copy link
Contributor

Summary

Getting the user ID is as important as getting the team ID. Since every Slack action is mostly performed by a user, and we already have logic to extract the user ID from the event's body, we can expose it on the context object like we expose the team ID.

Requirements (place an x in each [ ])

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @gilmatok to sign the Salesforce Inc. Contributor License Agreement.

@misscoded misscoded requested a review from seratch May 24, 2023 01:07
@seratch seratch added this to the 3.13.2 milestone May 24, 2023
@seratch seratch self-assigned this May 24, 2023
@seratch seratch added the enhancement M-T: A feature request for new functionality label May 24, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this PR; LGTM!

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1853 (ab80673) into main (a3532c3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head ab80673 differs from pull request most recent head c11997b. Consider uploading reports for the commit c11997b to get more accurate results

@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
+ Coverage   82.15%   82.18%   +0.02%     
==========================================
  Files          18       18              
  Lines        1519     1521       +2     
  Branches      435      436       +1     
==========================================
+ Hits         1248     1250       +2     
  Misses        175      175              
  Partials       96       96              
Impacted Files Coverage Δ
src/types/middleware.ts 100.00% <ø> (ø)
src/App.ts 83.82% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 60b9862 into slackapi:main May 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants