Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move node version to devDependencies #1894

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

WilliamBergamin
Copy link
Contributor

@WilliamBergamin WilliamBergamin commented Jul 11, 2023

Summary

Attempt to fix #1867

Let me know if this was all we needed to do for this, everything seems to work/pass

Requirements

@WilliamBergamin WilliamBergamin added the enhancement M-T: A feature request for new functionality label Jul 11, 2023
@WilliamBergamin WilliamBergamin added this to the 3.13.2 milestone Jul 11, 2023
@WilliamBergamin WilliamBergamin self-assigned this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1894 (79710f2) into main (0e82733) will not change coverage.
The diff coverage is n/a.

❗ Current head 79710f2 differs from pull request most recent head e1802a4. Consider uploading reports for the commit e1802a4 to get more accurate results

@@           Coverage Diff           @@
##             main    #1894   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          18       18           
  Lines        1521     1521           
  Branches      436      436           
=======================================
  Hits         1250     1250           
  Misses        175      175           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WilliamBergamin WilliamBergamin changed the title Update package.json Move node version to devDependencies Jul 11, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; indeed this should work 👍

@seratch seratch merged commit 4d67320 into slackapi:main Jul 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@types/node should not be set to an exact version in dependencies
2 participants