Socket mode using node v20

[WilliamBergamin]

Summary

This PR aims to solve #1917

In Node v19.5.0: A successful websocket.send returns a null value, instead of undefined, since this project supports Node v20 this use case must be handled properly.

Luckily slackapi/node-slack-sdk#1546 in the SocketModeClient resolves this issue, bumping @slack/socket-mode: ^1.3.0 to ^1.3.2 should fix the issue

testing

1. follow the README instructions and install the bolt-js-starter-template
2. Clone this repo and switch to the socket-mode-using-node-v20 branch
3. Make sure you are using Node v19.5.0 or higher
4. In your bolt-js-starter-template project
   a. run npm uninstall @slack/bolt
   b. run npm install /path/to/your/clone/bolt-js
5. run npm start
6. In slack, execute the /sample-command of the template app

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

Merging #1918 (aae0934) into main (ba5b893) will not change coverage.
The diff coverage is n/a.

❗ Current head aae0934 differs from pull request most recent head 6600e75. Consider uploading reports for the commit 6600e75 to get more accurate results

@@           Coverage Diff           @@
##             main    #1918   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          18       18           
  Lines        1521     1521           
  Branches      436      436           
=======================================
  Hits         1250     1250           
  Misses        175      175           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[filmaj]

Any ideas on what we could do to add a test and check for this? A test that would fail on main on node20 but pass in this branch?

[WilliamBergamin]

I'm not sure how to simply test this and prevent errors like this from coming up again 😟

it seems like we may need E2E tests to solve this, with Node v20 all the unit tests passed and the template app started with no issues, its only when a request from the SlackAPI came along that this error occurred

In theory we had already solved this problem, maybe we could force dependabot to keep up with the latests patch versions of our dependencies

[filmaj]

This does fix running in node v20 locally. Going to merge this and try to cut a release today, and we can think of how to prevent regressions on this issue moving forward in the background.