Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete every matrix test regardless of adjacent failures #2004

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Nov 29, 2023

Summary

This PR updates the CI checks complete every matrix test, regardless of other failures, for an improved debugging experience. Inspired by #2002.

Note: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

Requirements

@zimeg zimeg added semver:patch tests M-T: Testing work only labels Nov 29, 2023
@zimeg zimeg added this to the 3.16.0 milestone Nov 29, 2023
@zimeg zimeg self-assigned this Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8c78a1) 82.21% compared to head (75966ff) 82.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2004   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files          18       18           
  Lines        1524     1524           
  Branches      438      438           
=======================================
  Hits         1253     1253           
  Misses        175      175           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this. If this change is effective to make debugging specific Node version issues easier, I am fine to have it

@zimeg
Copy link
Member Author

zimeg commented Nov 29, 2023

@seratch thanks! I found it a smidge frustrating that some tests were being cancelled early and wouldn't complete, even on reruns. Hoping this removes that future frustration 🙏

@zimeg zimeg merged commit 3142f9a into slackapi:main Nov 29, 2023
8 checks passed
@zimeg zimeg deleted the no-fast-fails branch November 29, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants