Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#804] Fix AWS Lambda deploy guide using @vendia/serverless-express #806

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

mwbrooks
Copy link
Member

Summary

Fixes #804

This pull request updates the AWS Lambda deployment guide and example to fix the error serverlessExpress is not a fucntion.

We accomplish this by updating the @vendia/serverless-express package version to be 4.x.x or later. The earlier versions used the original .createServer and .proxy interface, while >=4.0.0 introduced a new single function interface.

I've updated the documentation and example app to use the latest version. In the guide, I call out that we required >=4.0.0 in case a developer uses an older version.

I've tested this locally using serverless-offline and on AWS Lambda.

Requirements (place an x in each [ ])

@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented area:examples issues related to example or sample code labels Feb 19, 2021
@mwbrooks mwbrooks self-assigned this Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #806 (3208d01) into main (0eca1ba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #806   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files          11       11           
  Lines        1089     1089           
  Branches      323      323           
=======================================
  Hits          713      713           
  Misses        317      317           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eca1ba...3208d01. Read the comment docs.

```

> 💡 This guide requires version `4.x.x` or later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this in the Japanese version?

💡 このガイドはバージョン 4.x.x 以上を必要とします

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in commit 3208d01 (I'll squash the merge).

Thanks for catching this! I need to get better at checking the Japanese docs when we do updates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks Thanks! Now you can merge this PR 👍

@mwbrooks mwbrooks merged commit ea5adc9 into slackapi:main Feb 19, 2021
@mwbrooks mwbrooks deleted the 804-aws-lambda-example-error branch February 19, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:examples issues related to example or sample code bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New AWS Lambda Example error: Failure: serverlessExpress is not a function
2 participants