Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncOAuthFlow run_installation missing team_name and enterprise_name fields in returned Installation #208

Closed
jwelch92 opened this issue Jan 15, 2021 · 2 comments · Fixed by #212
Assignees
Labels
area:async bug Something isn't working
Milestone

Comments

@jwelch92
Copy link

jwelch92 commented Jan 15, 2021

Reproducible in:

pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`

The slack_bolt version

slack-bolt==1.1.4
reproduced on fresh checkout of main

Python runtime version

Not relevant for this bug but Python 3.6.9.

OS info

N/A

Expected result:

See non-async OAuthFlow.run_installation

Actual result:

See AsyncOAuthFlow.run_installation

The fields team_name and enterprise_name are not pulled out of the request for use in the Installation.

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

@seratch seratch added this to the 1.2.2 milestone Jan 15, 2021
@seratch seratch added area:async bug Something isn't working labels Jan 15, 2021
@seratch seratch self-assigned this Jan 15, 2021
@seratch
Copy link
Member

seratch commented Jan 15, 2021

@jwelch92 Thanks a lot for taking the time to report this!

Yes, you are right. This is a bug in AsyncOAuthFlow. We will be fixing this issue early next week. If it is urgent for you, a workaround is to have your own AsyncOAuthFlow subclass and override the method.

@jwelch92
Copy link
Author

@jwelch92 Thanks a lot for taking the time to report this!

Yes, you are right. This is a bug in AsyncOAuthFlow. We will be fixing this issue early next week. If it is urgent for you, a workaround is to have your own AsyncOAuthFlow subclass and override the method.

Thanks @seratch! I ended up working around it for now but I will update as soon as this is fixed and released. I uncovered another unrelated issue while working on this so I'll file a separate ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants