Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1074 Customize user-facing message sent when an installation is not managed by bolt-python app #1077

Merged
merged 1 commit into from
May 9, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented May 8, 2024

This pull request resolves #1074

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added the enhancement New feature or request label May 8, 2024
@seratch seratch added this to the 1.19.0 milestone May 8, 2024
@seratch seratch self-assigned this May 8, 2024
@seratch seratch force-pushed the issue-1074-user-facing-message branch from cc4ec00 to f012327 Compare May 8, 2024 03:57
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.76%. Comparing base (e5131c9) to head (f012327).

Files Patch % Lines
...e/authorization/async_single_team_authorization.py 71.42% 2 Missing ⚠️
...dleware/authorization/single_team_authorization.py 50.00% 2 Missing ⚠️
...e/authorization/async_multi_teams_authorization.py 83.33% 1 Missing ⚠️
...dleware/authorization/multi_teams_authorization.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1077   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         181      181           
  Lines        6312     6315    +3     
=======================================
+ Hits         5792     5795    +3     
  Misses        520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch
Copy link
Member Author

seratch commented May 9, 2024

Thanks for the reviews!

@seratch seratch merged commit dbe2333 into slackapi:main May 9, 2024
12 checks passed
@seratch seratch deleted the issue-1074-user-facing-message branch May 9, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize user-facing message sent when an installation is not managed by bolt-python app
3 participants