Fix #307 Add options to disable the built-in middleware #310
+692
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 91.45% 91.56% +0.10%
==========================================
Files 166 166
Lines 5278 5286 +8
==========================================
+ Hits 4827 4840 +13
+ Misses 451 446 -5
Continue to review full report at Codecov.
|
seratch
commented
Apr 28, 2021
| @@ -169,47 +169,6 @@ def handle_app_mention(): | |||
| response = app.dispatch(request) | |||
| assert response.status == 200 | |||
|
|
|||
| def test_self_events(self): | |||
There was a problem hiding this comment.
I moved this to test_events_ignore_self.py
| say("What's up?") | ||
|
|
||
| # request including invalid headers | ||
| expired = int(time()) - 3600 |
There was a problem hiding this comment.
if the request verification is enabled, this request is rejected.
|
Thanks for reviewing this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #307 and also adds more options to disable the built-in middleware. Refer to my comment #307 (comment) for more details.
see also:
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.