Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #372 by adding listener matcher docs #402

Merged
merged 2 commits into from Jul 15, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jul 10, 2021

This pull request fixes #372 by updating the document about listener matchers.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added the docs Improvements or additions to documentation label Jul 10, 2021
@seratch seratch added this to the 1.7.0 milestone Jul 10, 2021
@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #402 (108ba90) into main (007d278) will increase coverage by 2.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   89.65%   91.72%   +2.07%     
==========================================
  Files         128      167      +39     
  Lines        3585     5437    +1852     
==========================================
+ Hits         3214     4987    +1773     
- Misses        371      450      +79     
Impacted Files Coverage Δ
slack_bolt/util/utils.py 84.61% <0.00%> (-5.87%) ⬇️
slack_bolt/request/async_request.py 94.28% <0.00%> (-5.72%) ⬇️
slack_bolt/request/async_internals.py 96.15% <0.00%> (-3.85%) ⬇️
slack_bolt/request/request.py 97.05% <0.00%> (-2.95%) ⬇️
slack_bolt/adapter/aws_lambda/chalice_handler.py 84.28% <0.00%> (-2.39%) ⬇️
slack_bolt/oauth/internals.py 97.77% <0.00%> (-2.23%) ⬇️
slack_bolt/version.py 100.00% <0.00%> (ø)
slack_bolt/__init__.py 100.00% <0.00%> (ø)
slack_bolt/async_app.py 100.00% <0.00%> (ø)
slack_bolt/app/__init__.py 100.00% <0.00%> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4988f...108ba90. Read the comment docs.

@seratch
Copy link
Member Author

seratch commented Jul 15, 2021

Let me merge this but please feel free to write in if you see something we can improve even after that!

@seratch seratch merged commit 1b4eefc into slackapi:main Jul 15, 2021
@seratch seratch deleted the issue-372-listener-matcher-docs branch July 15, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add listener matchers guide in documents
1 participant