Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint errors detected by pytype 2021.7.19 #416

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jul 21, 2021

This pull request fixes the CI build errors with the latest version of pytype.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #416 (2c9a40d) into main (7920f39) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2c9a40d differs from pull request most recent head e21e0a5. Consider uploading reports for the commit e21e0a5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         167      167           
  Lines        5488     5491    +3     
=======================================
+ Hits         5014     5017    +3     
  Misses        474      474           
Impacted Files Coverage Δ
...ack_bolt/adapter/aws_lambda/local_lambda_client.py 100.00% <ø> (ø)
slack_bolt/middleware/ssl_check/ssl_check.py 93.10% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7920f39...e21e0a5. Read the comment docs.

@seratch seratch merged commit f0d2699 into slackapi:main Jul 21, 2021
@seratch seratch deleted the pytype-2021.7.19 branch July 21, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant