Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a custom Executor in App #453

Merged
merged 6 commits into from
Aug 29, 2021
Merged

Allow a custom Executor in App #453

merged 6 commits into from
Aug 29, 2021

Commits on Aug 28, 2021

  1. Weaken typing for executors 

    It's not *required* that the executor be a ThreadPoolExecutor -- any
thread-based executor meeting the Executor interface would work. We can
weaken the type annotation to allow custom executors.
    @chrisbouchard
    chrisbouchard committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    e24e42d View commit details
    Browse the repository at this point in the history

  2. Allow a custom listener_executor in App constructor 

    Fixes slackapi#452
    @chrisbouchard
    chrisbouchard committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    56c6246 View commit details
    Browse the repository at this point in the history

  3. Add a scenario test for the new App constructor parameter

    @chrisbouchard
    chrisbouchard committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    14d56bc View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. Use markdown in App.__init__ docstring 

    Since it will be used by pydoc to generate the docs, we should use
markdown for formatting.
    @chrisbouchard
    chrisbouchard committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    8f27e9d View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Improved wording for documentation around the new `listener_executor` parameter.

Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
    @chrisbouchard @seratch
    chrisbouchard and seratch committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    79a80ed View commit details
    Browse the repository at this point in the history

  3. Update tests/scenario_tests/test_app.py

    @seratch
    seratch committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    fea77b9 View commit details
    Browse the repository at this point in the history