Add context 'user_id' extraction for 'message_changed' and 'message_deleted' events #736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
context.user_id
was not being set formessage_changed
ormessage_deleted
message
subtype events.user
is located in payload → event → message formessage_changed
events, and in payload → event → previous_message formessage_deleted
events.The first and third commits are for
message_changed
(with tests); the fourth commit is formessage_deleted
(with tests).The second commit addresses a typing issue I noticed by ensuring that
in
is not being compared toNone
(the original code would generate "in" not supported for type "None" warnings. I also removed the# type: ignore
comments on the associatedreturn
statements as they don't seem to be required.Category (place an
x
in each of the[ ]
)slack_bolt.App
and/or its core componentsslack_bolt.async_app.AsyncApp
and/or its core componentsslack_bolt.adapter
/docs
Requirements (place an
x
in each[ ]
)./scripts/install_all_and_run_tests.sh
after making the changes.