Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #738 Add more keyword args to say utility #741

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Oct 18, 2022

This pull request resolves #738

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.15.2 milestone Oct 18, 2022
@seratch seratch self-assigned this Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #741 (2d6fe0d) into main (4f1b4f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2d6fe0d differs from pull request most recent head 42c05c4. Consider uploading reports for the commit 42c05c4 to get more accurate results

@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         172      172           
  Lines        5873     5875    +2     
=======================================
+ Hits         5407     5409    +2     
  Misses        466      466           
Impacted Files Coverage Δ
slack_bolt/context/say/async_say.py 96.29% <100.00%> (+0.14%) ⬆️
slack_bolt/context/say/say.py 96.29% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 31146a2 into slackapi:main Oct 18, 2022
@seratch seratch deleted the issue-738-more-say-args branch October 18, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to set reply_broadcast in say() function?
1 participant