Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Handling views on close documentation #792

Merged
merged 3 commits into from
Dec 18, 2022
Merged

Adding Handling views on close documentation #792

merged 3 commits into from
Dec 18, 2022

Conversation

BrandonDalton
Copy link
Contributor

@BrandonDalton BrandonDalton commented Dec 17, 2022

Adding Handling Views on close to documentation based on issue #762 with the provided example code provided in #624. Followed similar documentation layout based on the javascript docs. https://slack.dev/bolt-js/concepts#view-submissions

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

Adding Handling Views on close to documentation based on issue #762
@seratch seratch added the docs Improvements or additions to documentation label Dec 17, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this PR! Could you check my comments? After merging this, we'll update the corresponding Japanese translation page too. I will work on it (I am a native Japanese speaker)

docs/_basic/listening_modals.md Outdated Show resolved Hide resolved
docs/_basic/listening_modals.md Outdated Show resolved Hide resolved
@seratch seratch added this to the 1.16.1 milestone Dec 17, 2022
BrandonDalton and others added 2 commits December 18, 2022 13:22
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@BrandonDalton
Copy link
Contributor Author

Thanks @seratch this has been done have a good weekend

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seratch seratch merged commit 6590c26 into slackapi:main Dec 18, 2022
seratch added a commit that referenced this pull request Dec 18, 2022
seratch added a commit that referenced this pull request Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants