Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the default handler when raise_error_for_unhandled_request is true #885

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 18, 2023

raise_error_for_unhandled_request=True is supposed to be used with a custom error handler. With that being said, the default behavior's logging could be confusing. To resolve the issue, this pull request chnges the internals to work with logger.exception better.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async area:sync labels Apr 18, 2023
@seratch seratch added this to the 1.17.2 milestone Apr 18, 2023
@seratch seratch self-assigned this Apr 18, 2023
@seratch seratch merged commit 7bf508f into slackapi:main Apr 18, 2023
8 of 9 checks passed
@seratch seratch deleted the raise_error_for_unhandled_request branch April 18, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async area:sync bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant