Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port parameter to web_app #917

Merged
merged 1 commit into from Jun 15, 2023
Merged

Conversation

butsyk
Copy link
Contributor

@butsyk butsyk commented Jun 14, 2023

(Describe the goal of this PR. Mention any related Issue numbers)

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @butsyk to sign the Salesforce Inc. Contributor License Agreement.

@seratch seratch added enhancement New feature or request area:async labels Jun 15, 2023
@seratch seratch added this to the 1.18.1 milestone Jun 15, 2023
@seratch seratch self-assigned this Jun 15, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me 👍

@seratch seratch merged commit b24e4cb into slackapi:main Jun 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants