Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the logging example so that it is valid JS #1172

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Oct 20, 2021

Summary

Tried copy+pasting the logging example and it didn't compile because it is not syntactically correct. Tweaking it to try to make it so!

Requirements (place an x in each [ ])

@filmaj filmaj added the docs M-T: Documentation work only label Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1172 (b254632) into main (bfe7fe6) will not change coverage.
The diff coverage is n/a.

❗ Current head b254632 differs from pull request most recent head e738c4f. Consider uploading reports for the commit e738c4f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files          15       15           
  Lines        1360     1360           
  Branches      405      405           
=======================================
  Hits          977      977           
  Misses        312      312           
  Partials       71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe7fe6...e738c4f. Read the comment docs.

Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@filmaj filmaj merged commit fc2c737 into main Oct 20, 2021
@filmaj filmaj deleted the fix-logging-example branch October 20, 2021 19:35
@seratch
Copy link
Member

seratch commented Oct 20, 2021

@filmaj Thanks for fixing this! Can you apply the same changes to Japanese page too?

@filmaj
Copy link
Contributor Author

filmaj commented Oct 20, 2021

Of course! Incoming shortly

@seratch seratch added this to the 3.8.0 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants